[Kde-hardware-devel] Review Request 117943: Port sendfile from KDELibs4Support

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117943/#review57275
-----------------------------------------------------------

Ship it!


This looks super awesome! 

- Àlex Fiestas


On May 2, 2014, 1:45 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117943/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 1:45 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> This patch removes all usage of KDELibs4Support in sendfile (src/sendfile).
> All string literals are also wrapped in QLatin1String/QStringLiteral.
> 
> Use QCommandLineParser instead of KCmdArgs. It does not support --license and --author options now.
> 
> There is one issue with native file dialog, QFileDialog::ExistingFiles mode (eg. select multiple files) doesn't work - it still allows to select only one file.
> It works fine with QFileDialog::DontUseNativeDialog option set to true.
> 
> 
> Diffs
> -----
> 
>   src/sendfile/CMakeLists.txt c5309ba 
>   src/sendfile/debug_p.h PRE-CREATION 
>   src/sendfile/debug_p.cpp PRE-CREATION 
>   src/sendfile/discoverwidget.cpp f16abee 
>   src/sendfile/main.cpp 79a78e8 
>   src/sendfile/pages/selectdeviceandfilespage.h ceb0674 
>   src/sendfile/pages/selectdeviceandfilespage.cpp e63806a 
>   src/sendfile/pages/selectdevicepage.cpp 142302a 
>   src/sendfile/pages/selectfilediscover.ui b85e85c 
>   src/sendfile/pages/selectfilespage.cpp 423b772 
>   src/sendfile/sendfilesjob.h e230a4a 
>   src/sendfile/sendfilesjob.cpp 339c3a5 
>   src/sendfile/sendfilewizard.cpp 87d156f 
> 
> Diff: https://git.reviewboard.kde.org/r/117943/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140504/39d01015/attachment.html>