[Kde-hardware-devel] Review Request 117927: Do not crash on systems without XRandr

Albert Astals Cid aacid at kde.org
Sat May 3 11:48:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117927/
-----------------------------------------------------------

(Updated May 3, 2014, 11:48 a.m.)


Status
------

This change has been marked as submitted.


Review request for Solid, Àlex Fiestas, Dan Vrátil, and Eugene Shalygin.


Repository: libkscreen


Description
-------

Deleting m_x11Helper on systems that don't have XRandr doesn't seem to work, so delay the initialization of it until the checks for XRandr have been made


Diffs
-----

  backends/xrandr1.1/xrandr11.cpp e6cd4de 

Diff: https://git.reviewboard.kde.org/r/117927/diff/


Testing
-------

The person with the crash in the bug reports the crash is gone (Well he reports he gets a different crash, but that's an okular mistake in assuming KScreen::Config::current can not return null)


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140503/516ef93b/attachment.html>


More information about the Kde-hardware-devel mailing list