[Kde-hardware-devel] Review Request 117927: Do not crash on systems without XRandr

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117927/#review57111
-----------------------------------------------------------

Ship it!


Makes sense. We do the same thing in the XRandR backend, so this should follow.

- Dan Vrátil


On May 1, 2014, 2:46 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117927/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 2:46 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas, Dan Vrátil, and Eugene Shalygin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> -------
> 
> Deleting m_x11Helper on systems that don't have XRandr doesn't seem to work, so delay the initialization of it until the checks for XRandr have been made
> 
> 
> Diffs
> -----
> 
>   backends/xrandr1.1/xrandr11.cpp e6cd4de 
> 
> Diff: https://git.reviewboard.kde.org/r/117927/diff/
> 
> 
> Testing
> -------
> 
> The person with the crash in the bug reports the crash is gone (Well he reports he gets a different crash, but that's an okular mistake in assuming KScreen::Config::current can not return null)
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140502/63722e59/attachment.html>