[Kde-hardware-devel] Review Request 118878: Fix incorrect filename when receiving files

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118878/
-----------------------------------------------------------

(Updated June 22, 2014, 5:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Bluedevil and Àlex Fiestas.


Repository: bluedevil


Description
-------

This patch fixes an issue that received file may be saved with incorrect name.

All incoming file transfers are temporarily downloaded into temp folder ($CACHE/obexd) and then moved to the target folder.
When there is already a file with the same name in temp folder, unique name is choosed (appending a number after original name).
The issue is that this modified name is used for the transfer (displayed in notification) and also for a final file (when copied from temp to target folder).

This patch should also go to master branch.


Diffs
-----

  src/daemon/kded/filereceiver/receivefilejob.h f520bac 
  src/daemon/kded/filereceiver/receivefilejob.cpp 2bce27f 

Diff: https://git.reviewboard.kde.org/r/118878/diff/


Testing
-------

Transfers always use correct filename regardless of contents of temp folder.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140622/e76edaf1/attachment.html>