[Kde-hardware-devel] Review Request 118878: Fix incorrect filename when receiving files

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118878/#review60715
-----------------------------------------------------------

Ship it!


Good to go, once you push it to master I will do further testing and make a new release.

Thanks!

- Àlex Fiestas


On June 22, 2014, 12:32 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118878/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 12:32 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> This patch fixes an issue that received file may be saved with incorrect name.
> 
> All incoming file transfers are temporarily downloaded into temp folder ($CACHE/obexd) and then moved to the target folder.
> When there is already a file with the same name in temp folder, unique name is choosed (appending a number after original name).
> The issue is that this modified name is used for the transfer (displayed in notification) and also for a final file (when copied from temp to target folder).
> 
> This patch should also go to master branch.
> 
> 
> Diffs
> -----
> 
>   src/daemon/kded/filereceiver/receivefilejob.h f520bac 
>   src/daemon/kded/filereceiver/receivefilejob.cpp 2bce27f 
> 
> Diff: https://git.reviewboard.kde.org/r/118878/diff/
> 
> 
> Testing
> -------
> 
> Transfers always use correct filename regardless of contents of temp folder.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140622/42e1cda9/attachment-0001.html>