[Kde-hardware-devel] Review Request 118877: Port kio modules away from KDELibs4Support

Àlex Fiestas afiestas at kde.org
Sun Jun 22 14:09:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118877/#review60713
-----------------------------------------------------------

Ship it!


It is good to go but tihis one port it to QCDebug before pushing please, the reason is because we really want to be able to redirect the output to a file and that will be free with the incoming QCDebug changes (KDebug had this features build in).

- Àlex Fiestas


On June 22, 2014, 12:32 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118877/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 12:32 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> This patch removes all usage of KDELibs4Support in kio modules (src/kio).
> 
> 
> Diffs
> -----
> 
>   src/kio/bluetooth/CMakeLists.txt 3c3e941 
>   src/kio/bluetooth/kiobluetooth.cpp 3a646f0 
>   src/kio/obexftp/CMakeLists.txt ae5c89a 
>   src/kio/obexftp/daemon/CMakeLists.txt 4926ee3 
>   src/kio/obexftp/daemon/ObexFtpDaemon.h 06ca7ac 
>   src/kio/obexftp/daemon/ObexFtpDaemon.cpp f443666 
>   src/kio/obexftp/daemon/createsessionjob.cpp 67733f5 
>   src/kio/obexftp/kio_obexftp.h d105f3c 
>   src/kio/obexftp/kio_obexftp.cpp 35d4067 
>   src/kio/obexftp/transferfilejob.cpp cf479c3 
> 
> Diff: https://git.reviewboard.kde.org/r/118877/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140622/2f95b964/attachment.html>


More information about the Kde-hardware-devel mailing list