[Kde-hardware-devel] Review Request 118875: Port wizard away from KDELibs4Support

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118875/#review60711
-----------------------------------------------------------

Ship it!


Looks good! The only thing I would do is to port to QCDebug instead of QDebug, but we can do that in another review.

Cheers!

- Àlex Fiestas


On June 22, 2014, 12:32 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118875/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 12:32 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> This patch removes all usage of KDELibs4Support in wizard (src/wizard).
> 
> 
> Diffs
> -----
> 
>   src/sendfile/main.cpp 5b24523 
>   src/wizard/CMakeLists.txt 1b88bec 
>   src/wizard/bluewizard.h fcb2015 
>   src/wizard/bluewizard.cpp 726a702 
>   src/wizard/main.cpp 1376a76 
>   src/wizard/pages/discoverpage.h 98f5352 
>   src/wizard/pages/discoverpage.cpp ce384ac 
>   src/wizard/pages/fail.h 1964788 
>   src/wizard/pages/fail.cpp 110f274 
>   src/wizard/pages/keyboardpairing.h 9b06a9a 
>   src/wizard/pages/keyboardpairing.cpp ff3d1e9 
>   src/wizard/pages/legacypairing.h c822bd5 
>   src/wizard/pages/legacypairing.cpp 7a954cc 
>   src/wizard/pages/legacypairingdatabase.h e9e13aa 
>   src/wizard/pages/legacypairingdatabase.cpp 6771169 
>   src/wizard/pages/nopairing.h 9b9f4bf 
>   src/wizard/pages/nopairing.cpp 754d968 
>   src/wizard/pages/ssppairing.h d8d0a79 
>   src/wizard/pages/ssppairing.cpp 675c9ec 
>   src/wizard/wizardagent.cpp 864d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/118875/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140622/d060a8f7/attachment-0001.html>