[Kde-hardware-devel] Review Request 118874: Port kcmodule away from KDELibs4Support

Àlex Fiestas afiestas at kde.org
Sun Jun 22 14:04:06 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118874/#review60709
-----------------------------------------------------------



src/kcmodule/sharedfilesdialog/sharedfilesdialog.cpp
<https://git.reviewboard.kde.org/r/118874/#comment42326>

    Move this else together with the }


- Àlex Fiestas


On June 22, 2014, 12:31 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118874/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 12:31 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> This patch removes all usage of KDELibs4Support in kcmodule (src/kcmodule).
> 
> I have also fixed bug in File Transfers -> Shared Files Dialog where it was needed to press "Remove" button twice for newly added files.
> It's a last line of diff.
> 
> 
> Diffs
> -----
> 
>   src/kcmodule/bluedeviladapters.h 8d30fb0 
>   src/kcmodule/CMakeLists.txt 2113c10 
>   src/kcmodule/bluedeviladapters.cpp 5c78df2 
>   src/kcmodule/bluedevildevices.h 02d4892 
>   src/kcmodule/bluedevildevices.cpp 65e526f 
>   src/kcmodule/bluedeviltransfer.h 87f205a 
>   src/kcmodule/bluedeviltransfer.cpp 3f90275 
>   src/kcmodule/devicedetails.h e30200f 
>   src/kcmodule/devicedetails.cpp c9abee9 
>   src/kcmodule/sharedfilesdialog/linkproxymodel.cpp 86db9d1 
>   src/kcmodule/sharedfilesdialog/sharedfiles.ui 0f62fe8 
>   src/kcmodule/sharedfilesdialog/sharedfilesdialog.h f1c25b9 
>   src/kcmodule/sharedfilesdialog/sharedfilesdialog.cpp cdc1ab9 
>   src/kcmodule/systemcheck.h e03daf9 
>   src/kcmodule/systemcheck.cpp 97d37b2 
>   src/kcmodule/transfer.ui 6c6cf74 
> 
> Diff: https://git.reviewboard.kde.org/r/118874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140622/40a9686c/attachment.html>


More information about the Kde-hardware-devel mailing list