[Kde-hardware-devel] Review Request 119170: Include ntdd* headers to make Solid build without the Windows DDK

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119170/#review63596
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Čec. 8, 2014, 5:20 dop., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119170/
> -----------------------------------------------------------
> 
> (Updated Čec. 8, 2014, 5:20 dop.)
> 
> 
> Review request for kdewin and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> The `ntdd*.h` headers used in the Windows backend come with MSVC2013 and MinGW, but not with MSVC2010, you have to download and install the DDK separately, or grab the headers from MinGW or kdewin. I don't know if MSVC2012 has them or not.
> 
> I added the headers to Solid, in a subdirectory. There is a CMake check using `check_cxx_source_compiles` to see if the headers are present in the system. The bundled headers are only added to the include search paths if they aren't already found in the system. This is more robust than checking the MSVC version number.
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/CMakeLists.txt 9271ae1 
>   src/solid/devices/backends/win/kdewin/ntddcdrm.h PRE-CREATION 
>   src/solid/devices/backends/win/kdewin/ntddmmc.h PRE-CREATION 
>   src/solid/devices/backends/win/kdewin/ntddstor.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119170/diff/
> 
> 
> Testing
> -------
> 
> Builds on MSVC2010 (didn't before) and MSVC2013 (did before).
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140731/a01e8a65/attachment.html>