[Kde-hardware-devel] Review Request 119087: Consider additional batteries for power management (when the critical battery timer is running)

[Emmanuel Pescosta]

> On July 28, 2014, 9:43 p.m., Kai Uwe Broulik wrote:
> > daemon/powerdevilcore.cpp, lines 286-290
> > <https://git.reviewboard.kde.org/r/119087/diff/1/?file=286670#file286670line286>
> >
> >     If you're already at it, you could use the currentChargePercent() method here, no?

Yep, good catch!


> On July 28, 2014, 9:43 p.m., Kai Uwe Broulik wrote:
> > daemon/powerdevilcore.cpp, line 700
> > <https://git.reviewboard.kde.org/r/119087/diff/1/?file=286670#file286670line700>
> >
> >     That's where "auto" comes in handy ;)

Changed :)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119087/#review63371
-----------------------------------------------------------


On July 29, 2014, 9:49 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119087/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 9:49 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Bugs: 325707, 329537 and 337414
>     https://bugs.kde.org/show_bug.cgi?id=325707
>     https://bugs.kde.org/show_bug.cgi?id=329537
>     https://bugs.kde.org/show_bug.cgi?id=337414
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> (kde:powerdevil version of review 118801)
> 
> After resuming from suspend, all batteries are added
> to powerdevil. When a battery, with charge lower or
> equal than the critical charge percentage is added, the
> critical battery timer will be started.
> 
> In the current version the critical battery timeout can
> only be interrupted by plugging in AC.
> 
> But if the system has more than one battery, the global
> charge percentage can be greater than the critical charge
> percentage and so the system shouldn't suspend. To achive
> this behaviour, we calculate the global charge percentage
> whenever a new battery was added and if the critical
> battery timer is running and the global charge is high
> enough, we stop the timer.
> 
> Also we use the already calculated global charge percentage
> for the battery charge percentage notification instead of
> the charge of each individual battery.
> 
> With this patch, the user can not only interrupt the critical
> timer by plugging in the AC but also by plugging in a new or
> additional battery (if the battery has enough charge).
> 
> 
> Diffs
> -----
> 
>   daemon/powerdevilcore.h dc2ba7e 
>   daemon/powerdevilcore.cpp 64791d6 
> 
> Diff: https://git.reviewboard.kde.org/r/119087/diff/
> 
> 
> Testing
> -------
> 
> Testing was done by Philipp Paris on his Thinkpad T440s (two
> batteries).
> 
> Two batteries above critical section:
> Resume after suspend works without the 30 sec timeout. (as current version)
> 
> One battery in critical section and the other above:
> Resume after suspend works without the 30 sec timeout. (changed behaviour)
> 
> Both in critical section:
> Resume after suspend without plugged in AC will go sleeping
> in 30 sec. (as current version)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140729/fed1eead/attachment-0001.html>