[Kde-hardware-devel] Review Request 119440: fix for bug #335466: typo "simlpy" (and others) in warning message

Martin Walch walch.martin at web.de
Thu Jul 24 17:34:16 UTC 2014



> On Juli 24, 2014, 10:32 vorm., Kai Uwe Broulik wrote:
> > Ship It!

Thank you for reviewing. However, I do not have an account and therefore I can not.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119440/#review63042
-----------------------------------------------------------


On Juli 23, 2014, 10:47 nachm., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119440/
> -----------------------------------------------------------
> 
> (Updated Juli 23, 2014, 10:47 nachm.)
> 
> 
> Review request for Solid.
> 
> 
> Bugs: 335466
>     https://bugs.kde.org/show_bug.cgi?id=335466
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Back in May I opened bug #335466 and posted this patch there.
> 
> This changes strings in a warning (kWarning()) message.
> 
> the changes are:
> * non existent -> non-existent
> * add a comma between "problem" and "or"
> * replace full stop with comma
> * simlpy -> simply
> 
> 
> Diffs
> -----
> 
>   daemon/powerdevilcore.cpp 64791d6 
> 
> Diff: https://git.reviewboard.kde.org/r/119440/diff/
> 
> 
> Testing
> -------
> 
> Initially, I applied this to the KDE/4.11 branch afair. It looks like this branch has been removed (?). Anyway, it also applies fine to master. However, I did not compile it with the latest state of the master branch since some dependency was missing.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140724/d93f10e7/attachment.html>


More information about the Kde-hardware-devel mailing list