[Kde-hardware-devel] Review Request 119381: not find ProvidersList

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119381/#review62769
-----------------------------------------------------------



libs/editor/mobileproviders.cpp
<https://git.reviewboard.kde.org/r/119381/#comment43511>

    This change is ok.



libs/editor/mobileproviders.cpp
<https://git.reviewboard.kde.org/r/119381/#comment43510>

    Is this really necessary? Constructing a UTF-8 QString from local8Bit data would give the same result as the original country QString. This looks redundant to me. Can you check if it still works without this change?


- Lamarque Souza


On July 21, 2014, 8:08 a.m., zhang jun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119381/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 8:08 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> When the system is in Chinese, country.length () is equal to 2, will not get country code. country must be converted to Local8Bit to find the appropriate country code.
> 
> 
> Diffs
> -----
> 
>   libs/editor/mobileproviders.cpp 886d32c 
> 
> Diff: https://git.reviewboard.kde.org/r/119381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhang jun
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140721/8691aa06/attachment.html>