[Kde-hardware-devel] Review Request 119349: typo in signal names ( upowermanager )

[Ömer Fadıl Usta]

> On July 18, 2014, 12:50 p.m., Lukáš Tinkl wrote:
> > Hmm, my upower (and also the newer one) has DeviceAdded/Removed signals... how did you come to this conclusion? Have you done any testing?

Yes you are right, after making test the result is same. Still getting no such Signal erros in my .xsesssion-errors file. I will discard this patch
but there is a problem about that signal


- Ömer Fadıl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119349/#review62638
-----------------------------------------------------------


On July 18, 2014, 8:31 a.m., Ömer Fadıl Usta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119349/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 8:31 a.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> There were some typos for signals in upowermanager such as ;
> DeviceAdded   -- >  deviceAdded
> DeviceRemoved  -- > deviceRemoved
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/backends/upower/upowermanager.cpp 53c8580 
> 
> Diff: https://git.reviewboard.kde.org/r/119349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140718/d80d78ee/attachment.html>