[Kde-hardware-devel] Review Request 114927: rename dbus interface files in solid

[Jonathan Riddell]

> On Jan. 27, 2014, 8:19 p.m., Jonathan Riddell wrote:
> > testing: successfully compiled and installed and did the same for kde-workspace/ksmserver and kde-workspace/powerdevil.  I couldn't work out how to test anything from a full neon5 plasma session but there should be no change in functionality with this diff.
> > 
> >
> 
> Àlex Fiestas wrote:
>     Have you tried compiling kde-workspace (specially kde-workspace/powerdevil) without kdelibs5 ? just some simple greping shows that kde-workspace/powerdevil/daemon/CMakeLists.txt uses these files.

Yes it needs this patch to compile 
https://git.reviewboard.kde.org/r/114928/


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114927/#review48412
-----------------------------------------------------------


On Jan. 27, 2014, 7:54 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114927/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 7:54 p.m.)
> 
> 
> Review request for Solid and Àlex Fiestas.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> libsolid installs dbus interface files which have the same filename as those from kdelibs4.  Many packagers are unable to work with this.
> 
> This proposal renames with a KF5 namespace the files installed.
> 
> It also does not install the freedesktop dbus files, source using these will need to bundle the files themselves.
> 
> 
> Diffs
> -----
> 
>   src/solid/CMakeLists.txt 84c254e 
> 
> Diff: https://git.reviewboard.kde.org/r/114927/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140128/9395d412/attachment.html>