[Kde-hardware-devel] Review Request 114927: rename dbus interface files in solid

[Michael Palimaka]

> On Jan. 25, 2014, 3:56 p.m., Scarlett Clark wrote:
> > This is becoming a big issue the farther into teir 3 packaging I get. In my humble opinion renaming the xml files (appending a 5) would make everything happy.
> 
> Michael Palimaka wrote:
>     In other frameworks, the change has been made so far by installing it with a kf5_ prefix. For solid however, this only fixes half the problem. A few org.freedesktop files collide, and apparently they cannot be renamed.
> 
> Scarlett Clark wrote:
>     Yeah, I am seeing that now, renaming breaks solid altogether. Further invesigating required...
> 
> Hrvoje Senjan wrote:
>     >A few org.freedesktop files collide, and apparently they cannot be renamed.
>     How so, that they cannot be renamed?

I read on the mailing list somewhere that those cannot be renamed because they are from freedesktop and other non-KDE things consume them. I can't personally vouch for that though.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114927/#review48265
-----------------------------------------------------------


On Jan. 22, 2014, 11:23 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114927/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 11:23 a.m.)
> 
> 
> Review request for Solid and Àlex Fiestas.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> libsolid installs dbus interface files which have the same filename as those from kdelibs4.  Many packagers are unable to work with this.
> 
> This proposal renames with a KF5 namespace the files installed.
> 
> It also does not install the freedesktop dbus files, source using these will need to bundle the files themselves.
> 
> 
> Diffs
> -----
> 
>   src/solid/org.kde.KF5Solid.PowerManagement.PolicyAgent.xml PRE-CREATION 
>   src/solid/CMakeLists.txt 0bc2abb 
>   src/solid/org.kde.KF5Solid.Networking.Client.xml PRE-CREATION 
>   src/solid/org.kde.Solid.Networking.Client.xml 70b46de 
>   src/solid/org.kde.Solid.PowerManagement.PolicyAgent.xml a07dd73 
>   src/solid/powermanagement.cpp 25d1ae6 
>   tests/CMakeLists.txt 5933708 
> 
> Diff: https://git.reviewboard.kde.org/r/114927/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140127/be1429b4/attachment.html>