[Kde-hardware-devel] Review Request 115271: Make sure that the right version of systemd is found as that git master systemd only returns a number

[Raymond Wooninck]

> On Jan. 23, 2014, 7:33 p.m., Kevin Krammer wrote:
> > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 52
> > <https://git.reviewboard.kde.org/r/115271/diff/1/?file=235518#file235518line52>
> >
> >     I think it would be better to read the string property into a local variable and then perform the two checks.
> >

I am trying to contact the systemd developers regarding this incompatibility, but no reply yet.  

The patch has been updated to use a regular expression, so that we only have to validate it once. 


- Raymond


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115271/#review48157
-----------------------------------------------------------


On Jan. 24, 2014, 10:26 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115271/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 10:26 a.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> The upcoming version of systemd (currently git master) seems to have its version string changed. Up to version 208, the string returned was "systemd xxx". With the current git master, only the version is returned. The version check within powerdevil is still expecting to get "systemd xxx" back and therefore fails with the systemd git master. 
> 
> The patch checks first if the "systemd xxx" string is returned and if not, it checks if just "xxx" is returned. 
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp eae5436 
> 
> Diff: https://git.reviewboard.kde.org/r/115271/diff/
> 
> 
> Testing
> -------
> 
> Testing done on a system with systemd git master and there the suspend and hibernate options are available again.
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140124/4b78c436/attachment-0001.html>