[Kde-hardware-devel] Review Request 115229: Reject Config with more enabled outputs than available CRTCs

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115229/
-----------------------------------------------------------

(Updated Jan. 22, 2014, 4:35 p.m.)


Review request for Solid and Àlex Fiestas.


Changes
-------

Fix XRandR1.1 backend


Repository: libkscreen


Description
-------

Config::canBeApplied() now rejects Configs that have more enabled outputs than is supported by GPU. We can't rely on drivers handling this situation, some don't (yup, looking at you, nouveau).

The maximum number of enabled outputs is exposed via a Screen property. In case of XRandR backends, this returns number of available CRTCs.


I will also add a check to KScreen KCM that will show an error and won't allow applying such configuration.


Diffs (updated)
-----

  backends/fake/parser.cpp f1f5d81 
  backends/xrandr/xrandrscreen.cpp d43aab1 
  backends/xrandr1.1/xrandr11.cpp b201181 
  src/config.cpp a473c2b 
  src/screen.h c85c7c2 
  src/screen.cpp 4446d7c 
  tests/configs/multipleclone.json 12ef4c0 
  tests/configs/multipleoutput.json 2b4a8d6 
  tests/configs/singleOutputWithoutPreferred.json 4e39647 
  tests/configs/singleoutput.json da5d08f 
  tests/configs/singleoutputBroken.json e3d88cb 
  tests/configs/tooManyOutputs.json PRE-CREATION 
  tests/testscreenconfig.cpp f40ea22 

Diff: https://git.reviewboard.kde.org/r/115229/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140122/d3802b73/attachment.html>