[Kde-hardware-devel] Review Request 107415: [High-dpi issues] Fix BluetoothDevicesDelegate with huge fonts and icon sizes

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107415/
-----------------------------------------------------------

(Updated Jan. 8, 2014, 7:52 p.m.)


Review request for Bluedevil, Àlex Fiestas and Michael Zanetti.


Changes
-------

Adressed Michael's comments and also made sure text never overlaps by returning an appropriate sizeHint.

I am now using qMax(font height * 2 + font xheight, icon size)
I couldn't find a method in QFontMetrics that gives me the distance between to lines of text, or an absolute height including everything. The lineSpacing() is the spacing from one line to another which is height() + leading() (leading was -1 in my case). If you have a better idea, go ahead, but it looks fine now :)


Repository: bluedevil


Description
-------

This fixes bluetooth devices delegate having overlapping fonts and small icons when using them with high dpi settings and big icon sizes, which is likely on high-dpi screens such as the Macbook Pro Retina.


Diffs (updated)
-----

  src/kcmodule/bluedevildevices.cpp ff15398 

Diff: https://git.reviewboard.kde.org/r/107415/diff/


Testing
-------

Tested with up to 200 dpi and bigger icons. This does not fix the initial problem but is an easy fix for the most common case (ie. if I have huge fonts I am likely to have huge icons as well, so when the icons are bigger, the fonts don't overlap if they are bigger as well).
Since there is no 48px default size, I am using Dialog icon size (default is 32) and multiply it by 1.5 to get the 48 which matches SizeLarge.


Screenshots
-----------

Bluedevil with 200 dpi
  https://git.reviewboard.kde.org/r/107415/s/846/


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140108/95a4dbe9/attachment.html>