[Kde-hardware-devel] Review Request 114172: Fix wrong signals/slot connection

Àlex Fiestas afiestas at kde.org
Tue Jan 7 05:36:15 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114172/#review46947
-----------------------------------------------------------

Ship it!


Ship It!

- Àlex Fiestas


On Nov. 28, 2013, 8:35 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114172/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 8:35 a.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> Fix some wrong connection between non-existant signals and slots.
> 
> I don't know the right way to fix:
> connect(adapter, SIGNAL(devicesChanged(QList<Device*>)), this, SLOT(adapterDevicesChanged()));
> 
> maybe this way?
> connect(adapter, SIGNAL(deviceChanged(Device*)), this, SLOT(adapterDevicesChanged()));
> 
> 
> Diffs
> -----
> 
>   src/actionplugins/sendfile/helper/discoverwidget.cpp 84756a3 
>   src/kcmodule/bluedevildevices.cpp 68ccdb2 
>   src/monolithic/monolithic.cpp 12e1d73 
> 
> Diff: https://git.reviewboard.kde.org/r/114172/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140107/53e7430e/attachment.html>


More information about the Kde-hardware-devel mailing list