[Kde-hardware-devel] Review Request 115420: workaround double call of PowerDevilUPowerBackend::brightnessKeyPressed after Fn+Brightness is press

Yichao Zhou broken.zhou at gmail.com
Sat Feb 1 12:11:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115420/
-----------------------------------------------------------

Review request for Solid.


Bugs: 276472
    http://bugs.kde.org/show_bug.cgi?id=276472


Repository: kde-workspace


Description
-------

In this patch, I
  1.  add a QElapsedTimer to prevent PowerDevilUPowerBackend::brightnessKeyPressed been called twice successively
  2.  let KDE override the BIOS's brightness change.  This makes the OSD show even if BIOS also handles the key press.  (It also because KDE allows more brightness level at my own laptop than my BIOS, but it may not be true for others.)


Diffs
-----

  powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp eae5436 

Diff: https://git.reviewboard.kde.org/r/115420/diff/


Testing
-------


Thanks,

Yichao Zhou

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140201/1725ed7b/attachment.html>


More information about the Kde-hardware-devel mailing list