[Kde-hardware-devel] Review Request 121606: Port bluetooth connection support to bluez 5

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121606/#review72522
-----------------------------------------------------------



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50568>

    Code style: the comma at the end of this line must go to the start of the next line. That helps to make the commit a bit shorter.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50569>

    Same here. Just fix those two issues and the patch is good to go. Thanks for patch.


- Lamarque Souza


On Dec. 26, 2014, 7:21 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121606/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 7:21 a.m.)
> 
> 
> Review request for Solid, Jan Grulich, Lukáš Tinkl, and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> bluez 5 + networkmanager 1.0.0 suppose to support dun connection, bluedevil for kf5 IMHO will support bluez 5. So this patch also drops bluez4 support completely.
> 
> nm 1.0.0's dun support doesn't require modemmanager AFAIK, so that part is dropped in this patch. (Not quite sure if nap is supported or not)
> 
> bluetoothdbustype.cpp is used because there's metatype conflict with libnm-qt, so declare the type in a separate file to avoid this.
> 
> 
> Diffs
> -----
> 
>   kded/CMakeLists.txt 910f5fa 
>   kded/bluetoothdbustype.h PRE-CREATION 
>   kded/bluetoothdbustype.cpp PRE-CREATION 
>   kded/bluetoothmonitor.h 5f43369 
>   kded/bluetoothmonitor.cpp 3aaf701 
>   kded/dbus/org.freedesktop.DBus.ObjectManager.xml PRE-CREATION 
>   kded/dbus/org.freedesktop.DBus.Properties.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121606/diff/
> 
> 
> Testing
> -------
> 
> qdbus org.kde.plasmanetworkmanagement /org/kde/plasmanetworkmanagement org.kde.plasmanetworkmanagement.addBluetoothConnection [macaddress] dun can now create connection.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141226/30e02875/attachment.html>