[Kde-hardware-devel] Review Request 121606: Port bluetooth connection support to bluez 5

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121606/#review72500
-----------------------------------------------------------



kded/bluetoothmonitor.h
<https://git.reviewboard.kde.org/r/121606/#comment50535>

    Move this line to the class' private section.



kded/bluetoothmonitor.h
<https://git.reviewboard.kde.org/r/121606/#comment50555>

    Code style: asterisk closer to variable name.



kded/bluetoothmonitor.h
<https://git.reviewboard.kde.org/r/121606/#comment50556>

    Same here.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50557>

    I think this line can be removed now.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50536>

    Use camel case in "oldowner" and "newowner".



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50537>

    code style: asterisk is closer to the variable name, not the type.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50538>

    Same here.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50539>

    Code style: start comments with capital letter and end them with period.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50541>

    Code style: add one space between type and asterisk (QDBusPendingCallWather<space>*).



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50540>

    Code style: & closer to the variable name.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50542>

    Code style: space after "if".



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50543>

    Code style: asterisk closer to variable name.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50544>

    Same here.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50545>

    Comment with inicial capital letter and period at the end.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50547>

    Code style: comments starting with capital letter and period at the end.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50548>

    Code style: capital letter at the start and period at the end.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50549>

    Code style: asterisk closer to variable name.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50550>

    Code style.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50551>

    Code style.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50552>

    Code style.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50553>

    Code style.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50558>

    When I implemented support for bluetooth connection I remember Alex Fiestas asking me to override if there was a connection with the same bluetooth address. That was decided like that because Bluetooth only presents the dialog to activate network service for the phone right after the pairing process. If we do not override the connection here the user will have to delete the connection in Connection Managerm unpair de bluetooth device and pair it again. By overriding  we do not force the user to manually delete the connection.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50554>

    Code style: prepend new line here and move the & closer to the variable name.


- Lamarque Souza


On Dec. 25, 2014, 2:58 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121606/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2014, 2:58 a.m.)
> 
> 
> Review request for Solid, Jan Grulich, Lukáš Tinkl, and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> bluez 5 + networkmanager 1.0.0 suppose to support dun connection, bluedevil for kf5 IMHO will support bluez 5. So this patch also drops bluez4 support completely.
> 
> nm 1.0.0's dun support doesn't require modemmanager AFAIK, so that part is dropped in this patch. (Not quite sure if nap is supported or not)
> 
> bluetoothdbustype.cpp is used because there's metatype conflict with libnm-qt, so declare the type in a separate file to avoid this.
> 
> 
> Diffs
> -----
> 
>   kded/bluetoothmonitor.cpp 3aaf701 
>   kded/dbus/org.freedesktop.DBus.Properties.xml PRE-CREATION 
>   kded/dbus/org.freedesktop.DBus.ObjectManager.xml PRE-CREATION 
>   kded/bluetoothmonitor.h 5f43369 
>   kded/bluetoothdbustype.cpp PRE-CREATION 
>   kded/CMakeLists.txt 910f5fa 
>   kded/bluetoothdbustype.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121606/diff/
> 
> 
> Testing
> -------
> 
> qdbus org.kde.plasmanetworkmanagement /org/kde/plasmanetworkmanagement org.kde.plasmanetworkmanagement.addBluetoothConnection [macaddress] dun can now create connection.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141225/a7318d49/attachment-0001.html>