[Kde-hardware-devel] Review Request 121606: Port bluetooth connection support to bluez 5

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121606/#review72476
-----------------------------------------------------------



kded/bluetoothdbustype.h
<https://git.reviewboard.kde.org/r/121606/#comment50518>

    You must add copyright and license header here and.



kded/bluetoothdbustype.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50523>

    Same here.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50524>

    This is wrong. QDBusPendingReply is async API, bluez.asyncCall() may not finish before reply.isError() is called below, that can lead to devices being ignored when they are available and working properly. Use QDBusReply instead. I did not like having to use sync API when I originally implemented support for bluetooth connections. If you can rewrite my code to use async API only I will really appreciate it.



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50525>

    const QString



kded/bluetoothmonitor.cpp
<https://git.reviewboard.kde.org/r/121606/#comment50526>

    Code style: space after "if"


- Lamarque Souza


On Dec. 23, 2014, 4:26 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121606/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 4:26 p.m.)
> 
> 
> Review request for Solid, Jan Grulich, Lukáš Tinkl, and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> bluez 5 + networkmanager 1.0.0 suppose to support dun connection, bluedevil for kf5 IMHO will support bluez 5. So this patch also drops bluez4 support completely.
> 
> nm 1.0.0's dun support doesn't require modemmanager AFAIK, so that part is dropped in this patch. (Not quite sure if nap is supported or not)
> 
> bluetoothdbustype.cpp is used because there's metatype conflict with libnm-qt, so declare the type in a separate file to avoid this.
> 
> 
> Diffs
> -----
> 
>   kded/CMakeLists.txt 910f5fa 
>   kded/bluetoothdbustype.h PRE-CREATION 
>   kded/bluetoothdbustype.cpp PRE-CREATION 
>   kded/bluetoothmonitor.h 5f43369 
>   kded/bluetoothmonitor.cpp 3aaf701 
> 
> Diff: https://git.reviewboard.kde.org/r/121606/diff/
> 
> 
> Testing
> -------
> 
> qdbus org.kde.plasmanetworkmanagement /org/kde/plasmanetworkmanagement org.kde.plasmanetworkmanagement.addBluetoothConnection [macaddress] dun can now create connection.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141224/948eb97c/attachment-0001.html>