[Kde-hardware-devel] Review Request 121506: Add setBrightnessSilent calls that don't show the OSD

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121506/#review72405
-----------------------------------------------------------

Ship it!


Ship It!

- Àlex Fiestas


On des. 14, 2014, 1 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121506/
> -----------------------------------------------------------
> 
> (Updated des. 14, 2014, 1 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Since the Explicit is also used in the policy manager, we cannot just use that one for the OSD. Instead I added separate "silent" calls that do the same as the regular ones but don't show the OSD. This is allows clients to decide whether they want the OSD to show (the default) or suppress it (Kamoso? or Battery monitor, when the user is actively dragging the slider there's no need for yet another popup confirming what he/she just did)
> 
> 
> Diffs
> -----
> 
>   daemon/actions/bundled/brightnesscontrol.h a179ade 
>   daemon/actions/bundled/brightnesscontrol.cpp 3bed569 
>   daemon/actions/bundled/keyboardbrightnesscontrol.h 243f620 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 42bbca3 
>   daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 5a5ea46 
>   daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 58a1b80 
> 
> Diff: https://git.reviewboard.kde.org/r/121506/diff/
> 
> 
> Testing
> -------
> 
> The calls work as expected for both keyboard and screen, both silent and normal.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141222/42329957/attachment.html>