[Kde-hardware-devel] Review Request 121603: Turn off keyboard in DPMS action

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121603/#review72342
-----------------------------------------------------------

Ship it!


Excellent little improvement!

- Àlex Fiestas


On des. 19, 2014, 9:22 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121603/
> -----------------------------------------------------------
> 
> (Updated des. 19, 2014, 9:22 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This makes it turn off the keyboard also in the DPMS action, I for instance don't like the dim display action and prefer DPMS only. It modifies the dim action to only touch the keyboard brightness if it is not off already to not cause races between the two.
> 
> 
> Diffs
> -----
> 
>   daemon/actions/bundled/dimdisplay.cpp e14f0a5 
>   daemon/actions/dpms/powerdevildpmsaction.h 71f9cce 
>   daemon/actions/dpms/powerdevildpmsaction.cpp f526d65 
> 
> Diff: https://git.reviewboard.kde.org/r/121603/diff/
> 
> 
> Testing
> -------
> 
> Tested using either of them or both at the same time. Works as expected, turns off keyboard in sync with the screen (as much as it can be synced given the dpms is handled by the X server) and turns back on when moving the mouse again.
> Don't know whether the C++11 initializer list I used it permitted here.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141220/68bc3f32/attachment.html>