[Kde-hardware-devel] Review Request 121364: Emit signal when maximum brightness changes

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121364/
-----------------------------------------------------------

(Updated Dec. 8, 2014, 4:45 p.m.)


Status
------

This change has been marked as submitted.


Review request for Solid.


Repository: powerdevil


Description
-------

This may sound unlikely but it could happen you plug in a illuminated USB keyboard, or the service is just not ready yet.

I don't know what Powerdevil does with the action though. Whether the keyboard action is not there at all then, or it has other means of announcing that. So perhaps this patch is the wrong approach but I can't think of a better idea.


Diffs
-----

  daemon/actions/bundled/brightnesscontrol.h a179ade 
  daemon/actions/bundled/brightnesscontrol.cpp 95e8914 
  daemon/actions/bundled/keyboardbrightnesscontrol.h 243f620 
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp 019d236 
  daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 5a5ea46 
  daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 58a1b80 

Diff: https://git.reviewboard.kde.org/r/121364/diff/


Testing
-------

I cannot really test that but the signal appears in qdbusviewer


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141208/a3153877/attachment.html>