[Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121386/#review71534
-----------------------------------------------------------


suggestion: use KWin's xcbutils.h for xcb stuff. But I must point out that xcbutils.h uses variadic templates and thus doesn't qualify frameworks compiler requirements.

If that is not an option: use auto a lot. The code is difficult to read with all the xcb_randr_foo_bar and in many cases it would be easier to read if it's just auto:
auto cookie is as obvious as xcb_randr_foo_bar_cookie_t cookie

- Martin Gräßlin


On Dec. 7, 2014, 10:36 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121386/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2014, 10:36 p.m.)
> 
> 
> Review request for Solid and Martin Gräßlin.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This ports the XRandrBacklight class to XCB.
> 
> The code is adapted from xbacklight, drops the legacy backlight stuff, whatever that is.
> 
> It still uses XSync since xcb_aux_sync yields a linker error here (what did I overlook?). Pretty ugly C stuff (fre...), suggestions on how to improve the code look (nullptr, C++ style casts, etc) welcome.
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/xrandrbrightness.h 873b1f5 
>   daemon/backends/upower/xrandrbrightness.cpp 8e5617d 
> 
> Diff: https://git.reviewboard.kde.org/r/121386/diff/
> 
> 
> Testing
> -------
> 
> My hopes were that it would give us a more precise backlight handling but I get a range of 0..10 nonetheless. Other than that seems to work exactly like it did before.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141208/2e140823/attachment.html>