[Kde-hardware-devel] Review Request 121343: fix battery remaining time update with upower > 0.99
Kai Uwe Broulik
kde at privat.broulik.de
Fri Dec 5 16:11:02 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121343/#review71434
-----------------------------------------------------------
Please in the future commit bugfixes to the stable branch and then just merge them to master. Thanks!
- Kai Uwe Broulik
On Dez. 5, 2014, 4:05 nachm., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121343/
> -----------------------------------------------------------
>
> (Updated Dez. 5, 2014, 4:05 nachm.)
>
>
> Review request for Solid and Lukáš Tinkl.
>
>
> Bugs: 339957
> https://bugs.kde.org/show_bug.cgi?id=339957
>
>
> Repository: powerdevil
>
>
> Description
> -------
>
> the connection to PropertiesChanged signal is only made in slotDeviceAdded, while the signal should also be connected for all existing devices.
>
>
> Diffs
> -----
>
> daemon/backends/upower/powerdevilupowerbackend.h f20eb37
> daemon/backends/upower/powerdevilupowerbackend.cpp 9f1c4e1
>
> Diff: https://git.reviewboard.kde.org/r/121343/diff/
>
>
> Testing
> -------
>
> battery remaining time is now being updated correctly.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141205/9aded254/attachment.html>
More information about the Kde-hardware-devel
mailing list