[Kde-hardware-devel] Review Request 121343: fix battery remaining time update with upower > 0.99

[Jan Grulich]

> On Pro. 4, 2014, 7:07 dop., Kai Uwe Broulik wrote:
> > That should fix https://bugs.kde.org/show_bug.cgi?id=339957
> 
> Xuetian Weng wrote:
>     Since reporter is using archlinux, which provides upower from git, then this must be the cause.

I'm testing it right now with upower 0.99 on Fedora 21 and it seems that the fix doesn't have any effect. It still shows 00:06:15 remaining all the time.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121343/#review71316
-----------------------------------------------------------


On Pro. 4, 2014, 7:22 dop., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121343/
> -----------------------------------------------------------
> 
> (Updated Pro. 4, 2014, 7:22 dop.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Bugs: 339957
>     https://bugs.kde.org/show_bug.cgi?id=339957
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> the connection to PropertiesChanged signal is only made in slotDeviceAdded, while the signal should also be connected for all existing devices.
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/powerdevilupowerbackend.h f20eb37 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 9f1c4e1 
> 
> Diff: https://git.reviewboard.kde.org/r/121343/diff/
> 
> 
> Testing
> -------
> 
> battery remaining time is now being updated correctly.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141204/19a7ef33/attachment.html>