[Kde-hardware-devel] Review Request 119731: Fix Request Scan reply

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119731/#review64363
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Grulich


On Srp. 12, 2014, 9:53 dop., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119731/
> -----------------------------------------------------------
> 
> (Updated Srp. 12, 2014, 9:53 dop.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> DBus signature doesn't match for RequestScan, in this case isError will set to true.
> 
> QDBusPendingReply without parameter always works.
> 
> 83254ab524d20969c42f23a1c809e4a5820a7e5f already fixed this for master.
> 
> 
> Diffs
> -----
> 
>   libs/handler.cpp e247dc5 
> 
> Diff: https://git.reviewboard.kde.org/r/119731/diff/
> 
> 
> Testing
> -------
> 
> No error messages send to knotify.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140812/ac2086b5/attachment.html>