[Kde-hardware-devel] Review Request 119440: fix for bug #335466: typo "simlpy" (and others) in warning message
Albert Astals Cid
aacid at kde.org
Sun Aug 10 22:44:07 UTC 2014
> On jul. 24, 2014, 10:32 a.m., Kai Uwe Broulik wrote:
> > Ship It!
>
> Martin Walch wrote:
> Thank you for reviewing. However, I do not have an account and therefore I can not.
I just pushed it.
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119440/#review63042
-----------------------------------------------------------
On ago. 10, 2014, 10:43 p.m., Martin Walch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119440/
> -----------------------------------------------------------
>
> (Updated ago. 10, 2014, 10:43 p.m.)
>
>
> Review request for Solid.
>
>
> Bugs: 335466
> https://bugs.kde.org/show_bug.cgi?id=335466
>
>
> Repository: powerdevil
>
>
> Description
> -------
>
> Back in May I opened bug #335466 and posted this patch there.
>
> This changes strings in a warning (kWarning()) message.
>
> the changes are:
> * non existent -> non-existent
> * add a comma between "problem" and "or"
> * replace full stop with comma
> * simlpy -> simply
>
>
> Diffs
> -----
>
> daemon/powerdevilcore.cpp 64791d6
>
> Diff: https://git.reviewboard.kde.org/r/119440/diff/
>
>
> Testing
> -------
>
> Initially, I applied this to the KDE/4.11 branch afair. It looks like this branch has been removed (?). Anyway, it also applies fine to master. However, I did not compile it with the latest state of the master branch since some dependency was missing.
>
>
> Thanks,
>
> Martin Walch
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140810/a7a0f328/attachment.html>
More information about the Kde-hardware-devel
mailing list