[Kde-hardware-devel] Review Request 117840: Port to Qt5

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117840/#review56993
-----------------------------------------------------------

Ship it!


It compiles so I guess it is good to go!

Would be nice to make libbluedevil a framework (http://community.kde.org/Frameworks/CreationGuidelines) but that can happen in another review.

Godd job!

- Àlex Fiestas


On April 28, 2014, 2:18 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117840/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 2:18 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: libbluedevil
> 
> 
> Description
> -------
> 
> This is a port of libbluedevil to Qt5.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5509d61 
>   bluedevil/CMakeLists.txt d3ac5fd 
>   bluedevil/bluedeviladapter.cpp 668934a 
>   bluedevil/bluedevildevice.cpp 884d015 
>   bluedevil/bluedevilmanager.cpp e5848be 
>   bluedevil/bluedevilmanager_p.cpp ad32470 
>   bluedevil/test/CMakeLists.txt 8f12785 
> 
> Diff: https://git.reviewboard.kde.org/r/117840/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140430/e95f0677/attachment.html>