[Kde-hardware-devel] Review Request 117298: Update XRandROutput after it's disabled so that cache is kept up-to-date.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117298/
-----------------------------------------------------------

(Updated April 1, 2014, 4:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Solid and Àlex Fiestas.


Repository: libkscreen


Description
-------

After disabling an output, we have to force-update the XRandROutput, because right after that we receive RRNotify_CRTCChange signal for that very output. This is propagated to users (like KCM), which then call canBeApplied(). canBeApplied() compares the KScreen::Config with the *outdated* XRandRConfig and that leads to a crash (because the XRandRConfig still claims that the output is enabled).

By updating the cache right after we disable the output, when KCM calls canBeApplied(), it's Config is compared to an up-to-date Config and everything is fine.


Diffs
-----

  backends/xrandr/xrandrconfig.cpp 04b37bd 

Diff: https://git.reviewboard.kde.org/r/117298/diff/


Testing
-------

Disabled a screen about 20 times without a single crash. Previously I was able to reproduce 100% of the time.


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140401/5d890ed9/attachment.html>