[Kde-hardware-devel] Review Request 112869: Do not leak sockets in kdelibs

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112869/
-----------------------------------------------------------

Review request for kdelibs and Solid.


Description
-------

NetworkInterface::isWireless() in kdelibs/solid/solid/backends/udev/udevnetworkinterface.cpp does not close the socket it opens to call an ioctl leading to problem to kded4 that can affect plasma-desktop as well (temporary freezing plasma-desktop as described in the bug entry).


This addresses bug 324954.
    http://bugs.kde.org/show_bug.cgi?id=324954


Diffs
-----

  solid/solid/backends/udev/udevnetworkinterface.cpp 06dc907 

Diff: http://git.reviewboard.kde.org/r/112869/diff/


Testing
-------

No testing but it is pretty obvious that we should not left that socket opened.


Thanks,

Lamarque Souza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130921/518201fe/attachment.html>