[Kde-hardware-devel] Review Request 113478: Fix brightness not being correctly reset on AC plugged-in

Lukáš Tinkl lukas at kde.org
Tue Oct 29 11:04:52 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113478/#review42617
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Oct. 28, 2013, 3:51 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113478/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 3:51 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Bugs: 326220
>     http://bugs.kde.org/show_bug.cgi?id=326220
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> the wake up from idle events comes later than loading the AC profile brightness, so the brightness in dimdisplay.cpp will reset the brightness after set brightness to new profile value.
> 
> KIdleTime::instance()->simulateUserActivity() doesn't trigger the onResumingFromIdle immediately ?from the behavior it's triggered afterwards in eventloop), so we manually call it here to make sure all old action is in good state.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 
>   powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
> 
> Diff: http://git.reviewboard.kde.org/r/113478/diff/
> 
> 
> Testing
> -------
> 
> Bug fixed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20131029/d81e2450/attachment.html>


More information about the Kde-hardware-devel mailing list