[Kde-hardware-devel] Review Request 113843: Implements a generic cloning method, and use it for displaySwitch and fallback.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113843/#review43600
-----------------------------------------------------------



kded/generator.cpp
<http://git.reviewboard.kde.org/r/113843/#comment31340>

    const :)



kded/generator.cpp
<http://git.reviewboard.kde.org/r/113843/#comment31341>

    const :)



kded/generator.cpp
<http://git.reviewboard.kde.org/r/113843/#comment31336>

    Make sure the list is not empty



kded/generator.cpp
<http://git.reviewboard.kde.org/r/113843/#comment31337>

    const :)



kded/generator.cpp
<http://git.reviewboard.kde.org/r/113843/#comment31339>

    const :)



kded/generator.cpp
<http://git.reviewboard.kde.org/r/113843/#comment31346>

    You can just use
    
    qSort(commonSizes);
    const QSize biggestSize  = commonSizes.first();


- Dan Vrátil


On Nov. 13, 2013, 4:26 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113843/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 4:26 p.m.)
> 
> 
> Review request for Solid and Dan Vrátil.
> 
> 
> Repository: kscreen
> 
> 
> Description
> -------
> 
> Generic cloning method that does the following:
> 
> -Gets a list of common sizes between all connected outputs modes and can be applied (Screen::maxWith/Height).
> -If none is found, clone using the biggest output (no checking if the picked mode works yet).
> -Selects the mode with the biggest applicable size and with the higher refreshRate.
> -Applies the changes.
> 
> 
> Diffs
> -----
> 
>   kded/generator.h a93261c 
>   kded/generator.cpp cc787a3 
>   tests/configs/workstationFallbackMode.json PRE-CREATION 
>   tests/testgenerator.cpp 92a438e 
> 
> Diff: http://git.reviewboard.kde.org/r/113843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20131113/6f278dcf/attachment.html>