[Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113587/#review42884
-----------------------------------------------------------



solid/solid/backends/fstab/fstabdevice.cpp
<http://git.reviewboard.kde.org/r/113587/#comment30996>

    Looks dangerous to me, what happens if there's nothing right of the equals sign?



solid/solid/backends/fstab/fstabdevice.cpp
<http://git.reviewboard.kde.org/r/113587/#comment30995>

    Put those in the same line.
    } else if (…) {



solid/solid/backends/fstab/fstabdevice.cpp
<http://git.reviewboard.kde.org/r/113587/#comment30997>

    Use curly braces even for one liners:
    if (…) {
        foo();
    }



solid/solid/backends/fstab/fstabdevice.cpp
<http://git.reviewboard.kde.org/r/113587/#comment31000>

    Needs i18n(c)?



solid/solid/backends/fstab/fstabdevice.cpp
<http://git.reviewboard.kde.org/r/113587/#comment30998>

    Same here.



solid/solid/backends/fstab/fstabdevice.cpp
<http://git.reviewboard.kde.org/r/113587/#comment30999>

    QLatin1String("network-server") ?


- Kai Uwe Broulik


On Nov. 3, 2013, 2:41 a.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113587/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2013, 2:41 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> These fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI
> For details, see https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/fstab/fstabdevice.h bac409e 
>   solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
>   solid/solid/backends/fstab/fstabhandling.h 4780a67 
>   solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
>   solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
>   solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
> 
> Diff: http://git.reviewboard.kde.org/r/113587/diff/
> 
> 
> Testing
> -------
> 
> Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has changed
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20131103/e354790e/attachment.html>