[Kde-hardware-devel] Review Request 110746: Bug 315017 - kded crashed while plug off the A/C

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110746/#review33520
-----------------------------------------------------------



powerdevil/daemon/powerdevilpolicyagent.cpp
<http://git.reviewboard.kde.org/r/110746/#comment24776>

    I do not like waitForFinished() calls. However, this is not part of your patch, so need to worry.



powerdevil/daemon/powerdevilpolicyagent.cpp
<http://git.reviewboard.kde.org/r/110746/#comment24775>

    isActive can be const here.



powerdevil/daemon/powerdevilpolicyagent.cpp
<http://git.reviewboard.kde.org/r/110746/#comment24774>

    As a small optimization you could add rp.isValid() to the if clause instead of creating a temporary variable (isActive).


- Lamarque Souza


On May 31, 2013, 12:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110746/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 12:24 p.m.)
> 
> 
> Review request for Solid and Daniel Nicoletti.
> 
> 
> Description
> -------
> 
> Fix Bug 315017 - kded crashed while plug off the A/C
> 
> There's a Qt bug which makes the application crash when you try to access a QDBusPendingReply value when it is invalid. This patch makes it check if the reply is valid before trying to access it.
> 
> 
> This addresses bug 315017.
>     http://bugs.kde.org/show_bug.cgi?id=315017
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/powerdevilpolicyagent.cpp e9d7ab3 
> 
> Diff: http://git.reviewboard.kde.org/r/110746/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130531/27b98403/attachment.html>