[Kde-hardware-devel] Review Request 110607: Add support for battery capacity
Kai Uwe Broulik
kde at privat.broulik.de
Fri May 24 19:12:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110607/
-----------------------------------------------------------
(Updated May 24, 2013, 7:12 p.m.)
Review request for Solid.
Changes
-------
Truncate values, don't round them
Description
-------
This patch adds support for the capacity property of batteries that tells how much energy can the battery hold compared to what it is designed to.
Diffs (updated)
-----
solid/solid/backends/fakehw/fakebattery.h 3ab180b
solid/solid/backends/fakehw/fakebattery.cpp d1907f6
solid/solid/backends/hal/halbattery.h 15590ad
solid/solid/backends/hal/halbattery.cpp d91a524
solid/solid/backends/upower/upowerbattery.h 576e06e
solid/solid/backends/upower/upowerbattery.cpp da0b877
solid/solid/battery.h 9a0929e
solid/solid/battery.cpp b3016cc
solid/solid/ifaces/battery.h 971914f
Diff: http://git.reviewboard.kde.org/r/110607/diff/
Testing
-------
Compiles.
Needs more testing. On my machine with recentmost UPower (or probably because I broken something) it does not return energy-full-design (which is needed obviously) which makes it fallback to 100% capacity.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130524/e8315a70/attachment.html>
More information about the Kde-hardware-devel
mailing list