[Kde-hardware-devel] Review Request 110384: Add isPowerSupply support to PowerDevil

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110384/
-----------------------------------------------------------

Review request for Solid.


Description
-------

This patch adds support for the "power supply" property in UPower batteries that tells if a battery is actually powering the machine (ie. laptop battery) or just inside a peripheral device (ie. mouse, keyboard, ..)

In the UDev backend it reads the power supply property, in HAL, which doesn't support this, we're assuming that primary battery and UPS battery are power supply and others are not (which is the current way PowerDevil for example determins whether a computer has a battery or not).

Not sure whether we need a powerSupplyStateChanged signal as the property is bound to the device and not meant to change? On the other hand, if an UPS kicks in, it might become a power supply?

This patch will in the end allow for example Plasma's battery monitor to only average battery percentage of batteries that are actually powering the machine, or PowerDevil to emit a separate message when your mouse battery goes low.


Diffs
-----

  solid/solid/backends/fakehw/fakebattery.h c7e2791 
  solid/solid/backends/fakehw/fakebattery.cpp 0afe765 
  solid/solid/backends/fakehw/fakecomputer.xml fe7e323 
  solid/solid/backends/hal/halbattery.h e2f38a0 
  solid/solid/backends/hal/halbattery.cpp 4c530da 
  solid/solid/backends/upower/upowerbattery.h 9d52f7b 
  solid/solid/backends/upower/upowerbattery.cpp 1a40a2a 
  solid/solid/battery.h 3afac6f 
  solid/solid/battery.cpp 37d7321 
  solid/solid/ifaces/battery.h 9987d18 

Diff: http://git.reviewboard.kde.org/r/110384/diff/


Testing
-------

After adjusting Plasma's powermanagement dataengine and battery monitor, I had it show two batteries (laptop battery and bluetooth mouse) and only take the laptop battery for battery percentage.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130510/846e4361/attachment.html>