[Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109384/#review29211
-----------------------------------------------------------


The code looks fine, thanks! 

There's another concern now, however (something that I haven't thought about before, sorry!) - if the code now depends on kdelibs, we don't fit Tear 1 in KDE Frameworks anymore. The question is whether we actually care, since this "workaround" can die with Solid2 asynchronous API, but still...

- Dan Vrátil


On March 14, 2013, 4:31 a.m., Alexander Mezin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109384/
> -----------------------------------------------------------
> 
> (Updated March 14, 2013, 4:31 a.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> While bug 261552 marked as fixed, optical drive spin-ups still happen more frequent than needed. Also, if there is a corrupted optical disk in the drive, a long delay happens when opening new file manager window (bug 306426).
> 
> This patch introduces a daemon that reads optical disks and remembers results, so disk access happens only once, usually right after new disk is inserted.
> This is for udisks2 backend, but should also work with udisks 1. The daemon doesn't contain any backend-specific code.
> 
> 
> This addresses bugs 261552 and 306426.
>     http://bugs.kde.org/show_bug.cgi?id=261552
>     http://bugs.kde.org/show_bug.cgi?id=306426
> 
> 
> Diffs
> -----
> 
>   solid/solid/CMakeLists.txt ab3f554 
>   solid/solid/backends/udisks2/udisksopticaldisc.h 0cdcc66 
>   solid/solid/backends/udisks2/udisksopticaldisc.cpp 23a4fc1 
>   solid/solid/diskscan/CMakeLists.txt PRE-CREATION 
>   solid/solid/diskscan/diskscanner.h PRE-CREATION 
>   solid/solid/diskscan/diskscanner.cpp PRE-CREATION 
>   solid/solid/diskscan/diskscannertask.h PRE-CREATION 
>   solid/solid/diskscan/diskscannertask.cpp PRE-CREATION 
>   solid/solid/diskscan/org.kde.Solid.DiskScanner.xml PRE-CREATION 
>   solid/solid/diskscan/soliddiskscan.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109384/diff/
> 
> 
> Testing
> -------
> 
> I tested it on top of kdelibs-4.10.1. Video DVDs are recognized correctly.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130314/1787afe2/attachment.html>