[Kde-hardware-devel] Review Request 109418: Workaround races between Solid::Backends::UDisks2::DeviceManager and DeviceBackends

[Alexander Mezin]

> On March 12, 2013, 12:33 p.m., Dan Vrátil wrote:
> > Ship It!

I don't have write access to repository, so you should commit it.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109418/#review29067
-----------------------------------------------------------


On March 11, 2013, 6:50 p.m., Alexander Mezin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109418/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 6:50 p.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> DeviceManager and DeviceBackends are subscribed to the same signals. DeviceManager's slots can be executed earlier than DeviceBackend's, so when deviceAdded signals are emitted by DeviceManager, DeviceBackend could contain non-updated data.
> Usually the problem appears with optical disks: device notifier shows inserted disks as generic storage volumes or shows wrong label.
> 
> Possible workaround is forcing refresh of DeviceBackend's property cache before emitting deviceAdded signal. For optical disks drive's properties should also be updated, because OpticalDisc reads drive's properties
> 
> 
> This addresses bug 314778.
>     http://bugs.kde.org/show_bug.cgi?id=314778
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/udisks2/udisksdevicebackend.h 829fa41 
>   solid/solid/backends/udisks2/udisksdevicebackend.cpp 2a01b86 
>   solid/solid/backends/udisks2/udisksmanager.h fb929ce 
>   solid/solid/backends/udisks2/udisksmanager.cpp 71b9e3e 
> 
> Diff: http://git.reviewboard.kde.org/r/109418/diff/
> 
> 
> Testing
> -------
> 
> Tested on KDE 4.10.1
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130313/9a9bae89/attachment.html>