[Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

[Alexander Mezin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109384/
-----------------------------------------------------------

(Updated March 11, 2013, 1:18 p.m.)


Review request for Solid and Lukáš Tinkl.


Description
-------

While bug 261552 marked as fixed, optical drive spin-ups still happen more frequent than needed. Also, if there is a corrupted optical disk in the drive, a long delay happens when opening new file manager window (bug 306426).

This patch introduces a daemon that reads optical disks and remembers results, so disk access happens only once, usually right after new disk is inserted.
This is for udisks2 backend, but should also work with udisks 1. The daemon doesn't contain any backend-specific code.


This addresses bugs 261552 and 306426.
    http://bugs.kde.org/show_bug.cgi?id=261552
    http://bugs.kde.org/show_bug.cgi?id=306426


Diffs
-----

  solid/solid/CMakeLists.txt 8142c7179686ee5b8381f4d336ca8296d4e6d4cd 
  solid/solid/backends/udisks2/diskscanner.h PRE-CREATION 
  solid/solid/backends/udisks2/diskscanner.cpp PRE-CREATION 
  solid/solid/backends/udisks2/org.kde.Solid.DiskScanner.service.cmake PRE-CREATION 
  solid/solid/backends/udisks2/udisksopticaldisc.h 0cdcc6698e3021394cfba949133f773677356651 
  solid/solid/backends/udisks2/udisksopticaldisc.cpp 23a4fc1fa56c9077529cc7d7409871c7636ed40f 

Diff: http://git.reviewboard.kde.org/r/109384/diff/


Testing
-------

I tested it on top of kdelibs-4.10.1. Video DVDs are recognized correctly.


Thanks,

Alexander Mezin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130311/23c351ff/attachment.html>