[Kde-hardware-devel] Review Request 110982: Disregard non-powersupply batteries for powerdevil

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110982/
-----------------------------------------------------------

(Updated June 13, 2013, noon)


Status
------

This change has been marked as submitted.


Review request for Solid.


Description
-------

Don't add non-powersupply batteries to the battery list.
I have seen a few peripheral device (in my case Apple Magic Mouse) that report themselves as primary battery errorneously but correctly set the power supply property. PowerDevil doesn't know of this and adds them to the list of batteries, resulting in false battery warnings, eg. your notebook battery is at 40% and your mouse almost empty it will trigger a "Your battery is low" notification.

In the future would of course be cool to handle those separately so we can notify "Your mouse is running low". But for now I guess this suffices, and so the notifications are consistent with what the new battery monitor tells.


Diffs
-----

  powerdevil/daemon/powerdevilcore.cpp 5815092 

Diff: http://git.reviewboard.kde.org/r/110982/diff/


Testing
-------

Nope, compiles. Looks safe though.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130613/7524b354/attachment.html>