[Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

[Andrea Scarpino]

> On June 5, 2013, 8:56 p.m., Lukáš Tinkl wrote:
> > Ship It!
> 
> Kevin Ottens wrote:
>     This change was wrong, it actually undo work previously done by George Goldberg.
>     See his commit e1d5e73ef26233694b87367dfcc50d857e278827.
>     
>     This patch being already submitted it should be reverted, and the missing uses of Q_DECLARE_TR_FUNCTIONS added.
> 
> Andrea Scarpino wrote:
>     Hi, is this ok? http://paste.kde.org/768098/
> 
> Kevin Ottens wrote:
>     Ah but that code got changed to use QCoreApplication::translate somehow... Well, for the part within formatByteSize() I wouldn't change it then. But the rest of your proposed change is fine (it's in a class which should have tr() just fine).

Yes, I fixed it in commit 33578e91e16286c729d60b7dcbc07f9900dd6390

I'll push the changes in description() then.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110841/#review33818
-----------------------------------------------------------


On June 5, 2013, 9 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110841/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 9 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> = subject.
> 
> Same code have been taken from commit 1576fd4df15b9cced4920b7ce0f49b467c5c081c
> 
> 
> Diffs
> -----
> 
>   tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp 5bbf2ac 
>   tier1/solid/src/solid/backends/udisks2/udisksdevicebackend.h 829fa41 
>   tier1/solid/src/solid/backends/udisks2/udisksdevicebackend.cpp 2a01b86 
> 
> Diff: http://git.reviewboard.kde.org/r/110841/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130610/177a0ace/attachment-0001.html>