[Kde-hardware-devel] Review Request 110930: Delay call to saveCurrentConfig() to prevent crash in case multiple events arrive

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110930/#review34028
-----------------------------------------------------------


This review has been submitted with commit ba0bb9abefa15bb2b6e773074e870491c8501761 by Dan Vrátil to branch master.

- Commit Hook


On June 10, 2013, 9:43 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110930/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 9:43 a.m.)
> 
> 
> Review request for Solid and Àlex Fiestas.
> 
> 
> Description
> -------
> 
> This crash is not easily reproduce on physical HW, but is easy to do in VirtualBox. Just install Guest Additions and start resizing the window. Every size change emits a XRandR event, so we can get insane amount of events within a very small time.
> 
> This patch adds a guard that will call saveConfig() only when there's no new event delivered for at least 300ms. With this patch, I can no longer crash KDED in VirtualBox (and trust me, I tried xD)
> 
> 
> This addresses bug 319878.
>     http://bugs.kde.org/show_bug.cgi?id=319878
> 
> 
> Diffs
> -----
> 
>   kded/daemon.h cdf0905 
>   kded/daemon.cpp d582ad6 
> 
> Diff: http://git.reviewboard.kde.org/r/110930/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130610/24969b7d/attachment.html>