[Kde-hardware-devel] Review Request 110433: bluedevil-wizard: Make it possible to select devices with a single click before pressing Next

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110433/#review33772
-----------------------------------------------------------

Ship it!


The changes looks ok, please go ahead and push it to master.

Thanks !

- Àlex Fiestas


On May 17, 2013, 7:48 p.m., Fabio D'Urso wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110433/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 7:48 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Description
> -------
> 
> In bluedevil-wizard's initial screen, the current code listens on the itemActivated signal of the device list. When it is emitted, the slot (itemSelected) sets some internal state referring to the currently selected device and, under the right conditions, enables the Next button.
> Depending on the configuration, itemActivated is triggered either by a single-click or a double-click.
> 
> I have a double-click configuration, therefore I have to double-click-on-the-device + press-Next in order to select a device. This feels very unnatural to me.
> Furthermore, if I only click once on the device, the Next button does not get enabled at all (because itemActivated is not emitted).
> 
> This patch makes it possible to just single-click-on-the-device + press-Next.
> 
> As I said on IRC, this patch is basically a revert of afiestas' commit de479d87cd07103f1f4e85b988f7197b4a329535, therefore I would very much appreciate his review on this patch.
> 
> 
> Diffs
> -----
> 
>   src/wizard/pages/discoverpage.cpp e9ba3ab 
> 
> Diff: http://git.reviewboard.kde.org/r/110433/diff/
> 
> 
> Testing
> -------
> 
> Tested UI interaction both with the mouse and the keyboard.
> 
> 
> Thanks,
> 
> Fabio D'Urso
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130604/83d725d7/attachment.html>