[Kde-hardware-devel] Review Request 109722: Make DeviceBackends thread-safe

[Alexander Mezin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109722/
-----------------------------------------------------------

(Updated July 31, 2013, 8:41 a.m.)


Status
------

This change has been discarded.


Review request for Solid and Lukáš Tinkl.


Description
-------

Cache for DeviceBackends was static, but there were no synchronization.
Instead of synchronizing everything, store the cache inside DeviceManager, as DeviceManagers are created per-thread.
    
To do this, I needed static getInstance() method in Ifaces::DeviceManager. Also, it may help in future.


Diffs
-----

  solid/solid/ifaces/devicemanager.h 3488d0b 
  solid/solid/devicemanager.cpp a465169 
  solid/solid/backends/udisks2/udisksmanager.cpp e76dfd1 
  solid/solid/backends/udisks2/udisksmanager.h 3961984 
  solid/solid/backends/udisks2/udisksdevicebackend.cpp 31ccbcf 
  solid/solid/backends/udisks2/udisksdevicebackend.h e7f3cc8 
  solid/solid/backends/udisks2/udisksdevice.cpp 1aa7b6d 

Diff: http://git.reviewboard.kde.org/r/109722/diff/


Testing
-------


Thanks,

Alexander Mezin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130731/a02912ac/attachment.html>