[Kde-hardware-devel] Review Request 111719: Add stub getters for isPowerSupply and capacity in IOKit battery interface

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111719/#review36544
-----------------------------------------------------------


This review has been submitted with commit b051ab6f2d3c6d16a91a429d57cf96af2e6b1fe1 by Kai Uwe Broulik to branch master.

- Commit Hook


On July 26, 2013, 12:40 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111719/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 12:40 p.m.)
> 
> 
> Review request for Solid, Kurt Hindenburg and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> This adds stub getter functions for isPowerSupply (which always returns true, we rather have all batteries (laptop battery *and* mice) respected rather than none) and capacity (which always returns 100%).
> Should make it compile on OSX?
> Didn't find any documentation about the properties I can fetch from IOKit (it probably has a capacity property, not sure about the powersupply thing)
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/iokit/iokitbattery.h 7827413 
>   solid/solid/backends/iokit/iokitbattery.cpp 55248d9 
> 
> Diff: http://git.reviewboard.kde.org/r/111719/diff/
> 
> 
> Testing
> -------
> 
> Nope.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130726/2b27189e/attachment.html>