[Kde-hardware-devel] Review Request 111717: Fix frequently spinning optical drive by caching data in shared memory

[Alexander Mezin]

> On July 26, 2013, 6:17 p.m., Lukáš Tinkl wrote:
> > Please do more testing with different media types (audio, video, blank), otherwise the code looks good
> 
> Alexander Mezin wrote:
>     Tested with blank media and video cd. Didn't notice any problems, video cd is detected correctly.

I heard that 4.11 will be a long-term release. Could this change be included in 4.11?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111717/#review36532
-----------------------------------------------------------


On July 26, 2013, 6:14 p.m., Alexander Mezin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111717/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 6:14 p.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> With this patch optical drive doesn't start spinning when new Dolphin window or file dialog is opened. No daemons, just single shared memory block.
> 
> 
> This addresses bug 261552.
>     http://bugs.kde.org/show_bug.cgi?id=261552
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/udisks2/udisksopticaldisc.cpp 23a4fc1 
>   solid/solid/backends/udisks2/udisksopticaldisc.h 0cdcc66 
> 
> Diff: http://git.reviewboard.kde.org/r/111717/diff/
> 
> 
> Testing
> -------
> 
> Tested on top of kdelibs 4.11 rc 2. At least it can find pictures on disk, so I think it works.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130726/4d202a6a/attachment.html>